Terrier Core

Logging improvements

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 3.0
  • Fix Version/s: 3.5
  • Component/s: None
  • Description:
    Hide
    Terrier uses the root logger [i.e. logger = Logger.getRootLogger();] in most places loggers are created. This makes logger configuration difficult (for example if you just want messages from a certain class). Using logger = Logger.getLogger(xxx.class) where xxx is the name of the class holding the logger is much more flexible.
    Show
    Terrier uses the root logger [i.e. logger = Logger.getRootLogger();] in most places loggers are created. This makes logger configuration difficult (for example if you just want messages from a certain class). Using logger = Logger.getLogger(xxx.class) where xxx is the name of the class holding the logger is much more flexible.

Issue Links

Activity

Hide
Craig Macdonald added a comment - 31/Mar/11 4:35 PM

Thanks for creating this issue. Indeed this is an issue, I have slowly been trying to fix these.

Show
Craig Macdonald added a comment - 31/Mar/11 4:35 PM Thanks for creating this issue. Indeed this is an issue, I have slowly been trying to fix these.
Hide
Craig Macdonald added a comment - 31/Mar/11 4:35 PM

Trivial to fix once and for all. Tagging for 3.1.

Show
Craig Macdonald added a comment - 31/Mar/11 4:35 PM Trivial to fix once and for all. Tagging for 3.1.
Hide
Craig Macdonald added a comment - 31/Mar/11 4:38 PM

List of remaining files to fix:

src/core/org/terrier/terms/Stopwords.java
src/core/org/terrier/indexing/WARC09Collection.java
src/core/org/terrier/indexing/TRECCollection.java
src/core/org/terrier/indexing/MSWordDocument.java
src/core/org/terrier/indexing/MSPowerpointDocument.java
src/core/org/terrier/indexing/Indexer.java
src/core/org/terrier/indexing/PDFDocument.java
src/core/org/terrier/indexing/TRECFullTokenizer.java
src/core/org/terrier/indexing/MSExcelDocument.java
src/core/org/terrier/indexing/TaggedDocument.java
src/core/org/terrier/indexing/SimpleXMLCollection.java
src/core/org/terrier/indexing/CollectionFactory.java
src/core/org/terrier/indexing/FileDocument.java
src/core/org/terrier/applications/TRECIndexing.java
src/core/org/terrier/applications/desktop/DesktopTerrier.java
src/core/org/terrier/applications/desktop/IndexFolders.java
src/core/org/terrier/applications/TrecTerrier.java
src/core/org/terrier/applications/TRECQuerying.java
src/core/org/terrier/applications/TRECQueryingExpansion.java
src/core/org/terrier/evaluation/AdhocEvaluation.java
src/core/org/terrier/evaluation/AdhocFullQueryEvaluation.java
src/core/org/terrier/evaluation/Evaluation.java
src/core/org/terrier/evaluation/TRECQrelsInMemory.java
src/core/org/terrier/structures/merging/LexiconMerger.java
src/core/org/terrier/structures/indexing/singlepass/MemoryPostings.java
src/core/org/terrier/structures/Index.java
src/core/org/terrier/structures/BlockDirectIndex.java
src/core/org/terrier/structures/TRECQuery.java
src/core/org/terrier/utility/ApplicationSetup.java
src/core/org/terrier/matching/QueryResultSet.java
src/core/org/terrier/matching/CollectionResultSet.java
src/core/org/terrier/matching/dsms/BooleanFallback.java
src/core/org/terrier/matching/dsms/PhraseScoreModifier.java
src/core/org/terrier/matching/dsms/BlockScoreModifier.java
src/core/org/terrier/matching/AccumulatorResultSet.java
src/core/org/terrier/compression/BitOutputStream.java
src/core/org/terrier/querying/QueryExpansion.java
src/core/org/terrier/querying/DFRBagExpansionTerms.java
src/core/org/terrier/querying/parser/Main.java
src/core/org/terrier/querying/Manager.java
Show
Craig Macdonald added a comment - 31/Mar/11 4:38 PM List of remaining files to fix:
src/core/org/terrier/terms/Stopwords.java
src/core/org/terrier/indexing/WARC09Collection.java
src/core/org/terrier/indexing/TRECCollection.java
src/core/org/terrier/indexing/MSWordDocument.java
src/core/org/terrier/indexing/MSPowerpointDocument.java
src/core/org/terrier/indexing/Indexer.java
src/core/org/terrier/indexing/PDFDocument.java
src/core/org/terrier/indexing/TRECFullTokenizer.java
src/core/org/terrier/indexing/MSExcelDocument.java
src/core/org/terrier/indexing/TaggedDocument.java
src/core/org/terrier/indexing/SimpleXMLCollection.java
src/core/org/terrier/indexing/CollectionFactory.java
src/core/org/terrier/indexing/FileDocument.java
src/core/org/terrier/applications/TRECIndexing.java
src/core/org/terrier/applications/desktop/DesktopTerrier.java
src/core/org/terrier/applications/desktop/IndexFolders.java
src/core/org/terrier/applications/TrecTerrier.java
src/core/org/terrier/applications/TRECQuerying.java
src/core/org/terrier/applications/TRECQueryingExpansion.java
src/core/org/terrier/evaluation/AdhocEvaluation.java
src/core/org/terrier/evaluation/AdhocFullQueryEvaluation.java
src/core/org/terrier/evaluation/Evaluation.java
src/core/org/terrier/evaluation/TRECQrelsInMemory.java
src/core/org/terrier/structures/merging/LexiconMerger.java
src/core/org/terrier/structures/indexing/singlepass/MemoryPostings.java
src/core/org/terrier/structures/Index.java
src/core/org/terrier/structures/BlockDirectIndex.java
src/core/org/terrier/structures/TRECQuery.java
src/core/org/terrier/utility/ApplicationSetup.java
src/core/org/terrier/matching/QueryResultSet.java
src/core/org/terrier/matching/CollectionResultSet.java
src/core/org/terrier/matching/dsms/BooleanFallback.java
src/core/org/terrier/matching/dsms/PhraseScoreModifier.java
src/core/org/terrier/matching/dsms/BlockScoreModifier.java
src/core/org/terrier/matching/AccumulatorResultSet.java
src/core/org/terrier/compression/BitOutputStream.java
src/core/org/terrier/querying/QueryExpansion.java
src/core/org/terrier/querying/DFRBagExpansionTerms.java
src/core/org/terrier/querying/parser/Main.java
src/core/org/terrier/querying/Manager.java
Hide
Craig Macdonald added a comment - 05/Apr/11 6:42 PM

Committed to trunk. Thanks Nut!

Show
Craig Macdonald added a comment - 05/Apr/11 6:42 PM Committed to trunk. Thanks Nut!

People

Dates

  • Created:
    31/Mar/11 4:32 PM
    Updated:
    05/Apr/11 6:42 PM
    Resolved:
    05/Apr/11 6:42 PM